Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase GHO Facilitator Capacity #374

Merged
merged 11 commits into from
Jul 19, 2024
Merged

Increase GHO Facilitator Capacity #374

merged 11 commits into from
Jul 19, 2024

Conversation

efecarranza
Copy link
Contributor

Changelog

Increase GHO facilitator capacity.

@efecarranza efecarranza marked this pull request as draft July 8, 2024 21:22
@efecarranza efecarranza marked this pull request as ready for review July 10, 2024 00:34
@miguelmtzinf
Copy link
Contributor

Changes to the bridge limit and the facilitator bucket capacity of CCIP on Arbitrum can result in users being locked. This occurs because the minting of GHO at the destination can revert if the bucket capacity is maxed out. More information about this issue can be found in the governance discussion.

This creates a poor UX, as users have no immediate solution other than to "wait and retry"—waiting for a bucket capacity increase to retry and get their tokens minted. The CCIP explorer provides a user-friendly UI for transaction retries.

Lock-ups can occur with both bucket capacity increases and decreases. However, bucket capacity decreases are more problematic because users will remain locked until the bucket capacity is raised again, which might not happen soon. In the case of bucket increases, users can get temporarily locked until the bucket capacity change is applied at the destination.

@brotherlymite
Copy link
Contributor

Does it make sense that we pause robot execution for both the payloads and execute it manually on both networks together to prevent any gap.
As the general case is the payload on ethereum gets executed 5-10mins before arbitrum so it could be the case the bridgeLimit on ethereum is increased before the facilitator limit on arbitrum, and if the facilitator was full before the user would need to retry on arbitrum when payload on arbitrum is executed. Or it its not a big issue and ask the user to retry, we can keep it the way it is.
Opinion @miguelmtzinf @efecarranza?

@miguelmtzinf
Copy link
Contributor

miguelmtzinf commented Jul 16, 2024 •
edited
Loading

Given that it is a bucket capacity increase and destination is not maxed out, it's unlikely to have user lock ups. However, we can disable Robot in this case so steps can be executed in the optimal order to do not diminish UX.

@efecarranza
Copy link
Contributor Author

@brotherlymite @miguelmtzinf i added the e2e test and general modifications.
however, now capacity is at the limit so we might need to pause the bot for this execution.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

Foundry report

forge 0.2.0 (e903484 2024-07-19T00:35:00.583275743Z)
Build log 
Compiling 467 files with Solc 0.8.19
Solc 0.8.19 finished in 267.22s
Compiler run successful with warnings:
Warning (3628): This contract has a payable fallback function, but no receive ether function. Consider adding a receive ether function.
  --> src/20240502_AaveV1Ethereum_AaveV1Deprecation/AaveV1Ethereum_AaveV1Deprecation_20240502.t.sol:94:1:
   |
94 | contract AaveV1Ethereum_AaveV1Deprecation_20240502_Test is ProtocolV3TestBase {
   | ^ (Relevant source part starts here and spans across multiple lines).
Note: The payable fallback function is defined here.
   --> src/20240502_AaveV1Ethereum_AaveV1Deprecation/AaveV1Ethereum_AaveV1Deprecation_20240502.t.sol:297:3:
    |
297 |   fallback() external payable {}
    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Warning (2018): Function state mutability can be restricted to pure
   --> lib/aave-helpers/src/ProtocolV2TestBase.sol:662:3:
    |
662 |   function _logReserveConfig(ReserveConfig memory config) internal view {
    |   ^ (Relevant source part starts here and spans across multiple lines).

Warning (2018): Function state mutability can be restricted to pure
   --> lib/aave-helpers/src/ProtocolV3TestBase.sol:824:3:
    |
824 |   function _logReserveConfig(ReserveConfig memory config) internal view {
    |   ^ (Relevant source part starts here and spans across multiple lines).

Warning (2018): Function state mutability can be restricted to view
  --> src/20240421_AaveV3Ethereum_LlamariskRiskProvider/AaveV3Ethereum_LlamariskRiskProvider_20240421.t.sol:53:3:
   |
53 |   function _validateGhoStreamConfig(uint256 streamId) internal {
   |   ^ (Relevant source part starts here and spans across multiple lines).

Warning (2018): Function state mutability can be restricted to view
   --> src/20240528_Multi_GHOCrossChainLaunch/AaveV3Arbitrum_GHOCrossChainLaunch_20240528.t.sol:275:3:
    |
275 |   function _validateGhoDeployment() internal {
    |   ^ (Relevant source part starts here and spans across multiple lines).

Warning (2018): Function state mutability can be restricted to view
   --> src/20240528_Multi_GHOCrossChainLaunch/AaveV3Arbitrum_GHOCrossChainLaunch_20240528.t.sol:284:3:
    |
284 |   function _validateCcipTokenPool() internal {
    |   ^ (Relevant source part starts here and spans across multiple lines).

Warning (2018): Function state mutability can be restricted to view
   --> src/20240528_Multi_GHOCrossChainLaunch/AaveV3Ethereum_GHOCrossChainLaunch_20240528.t.sol:245:3:
    |
245 |   function _validateCcipTokenPool() internal {
    |   ^ (Relevant source part starts here and spans across multiple lines).

| Contract                                                                      | Size (B) | Margin (B) |
|-------------------------------------------------------------------------------|----------|------------|
| AaveGovernanceV2                                                              |       45 |     24,531 |
| AaveSafetyModule                                                              |       45 |     24,531 |
| AaveSwapper                                                                   |    5,572 |     19,004 |
| AaveV1                                                                        |       45 |     24,531 |
| AaveV1Ethereum_AaveV1Deprecation_20240502                                     |    2,593 |     21,983 |
| AaveV2Avalanche                                                               |       45 |     24,531 |
| AaveV2AvalancheAssets                                                         |       45 |     24,531 |
| AaveV2Avalanche_LTLTVReductionsOnAaveV2Stablecoins_20240510                   |      210 |     24,366 |
| AaveV2Avalanche_MigrateRobotsToChainlinkAutomationV2_20240422                 |      518 |     24,058 |
| AaveV2Avalanche_ReserveFactorUpgrades_20240506                                |    1,022 |     23,554 |
| AaveV2Avalanche_ReserveFactorUpgrades_20240524                                |    1,022 |     23,554 |
| AaveV2Avalanche_ReserveFactorUpgrades_20240528                                |    1,022 |     23,554 |
| AaveV2Avalanche_StablecoinIRUpdates_20240424                                  |    1,858 |     22,718 |
| AaveV2Avalanche_TemporaryFreezeOfLongTailV2Assets_20240418                    |      186 |     24,390 |
| AaveV2Ethereum                                                                |       45 |     24,531 |
| AaveV2EthereumAMM                                                             |       45 |     24,531 |
| AaveV2EthereumAMMAssets                                                       |       45 |     24,531 |
| AaveV2EthereumAssets                                                          |       45 |     24,531 |
| AaveV2Ethereum_AAMPLSecondDistribution_20240429                               |    2,370 |     22,206 |
| AaveV2Ethereum_AprilFinanceUpdate_20240421                                    |    7,897 |     16,679 |
| AaveV2Ethereum_ChaosLabsEthereumV2LTReductions_20240509                       |      358 |     24,218 |
| AaveV2Ethereum_DeprecationOfSmallCapStablecoinsOnV2Ethereum_20240502          |    3,472 |     21,104 |
| AaveV2Ethereum_LTLTVReductionsOnAaveV2Stablecoins_20240510                    |      210 |     24,366 |
| AaveV2Ethereum_ReserveFactorUpgrades_20240506                                 |    1,778 |     22,798 |
| AaveV2Ethereum_ReserveFactorUpgrades_20240524                                 |    1,778 |     22,798 |
| AaveV2Ethereum_ReserveFactorUpgrades_20240528                                 |    1,022 |     23,554 |
| AaveV2Ethereum_StablecoinIRCurveAmendment_20240714                            |    1,858 |     22,718 |
| AaveV2Ethereum_StablecoinIRUpdates_20240424                                   |    1,858 |     22,718 |
| AaveV2Ethereum_TemporaryFreezeOfLongTailV2Assets_20240418                     |      793 |     23,783 |
| AaveV2Polygon                                                                 |       45 |     24,531 |
| AaveV2PolygonAssets                                                           |       45 |     24,531 |
| AaveV2Polygon_AprilFinanceUpdate_20240421                                     |    6,129 |     18,447 |
| AaveV2Polygon_AprilFinanceUpdate_20240421_PartB                               |      451 |     24,125 |
| AaveV2Polygon_BorrowRateUpdates_20240528                                      |    2,896 |     21,680 |
| AaveV2Polygon_LTLTVReductionsOnAaveV2Stablecoins_20240510                     |      210 |     24,366 |
| AaveV2Polygon_MigrateRobotsToChainlinkAutomationV2_20240422                   |      518 |     24,058 |
| AaveV2Polygon_TemporaryFreezeOfLongTailV2Assets_20240418                      |      186 |     24,390 |
| AaveV3Arbitrum                                                                |       45 |     24,531 |
| AaveV3ArbitrumAssets                                                          |       45 |     24,531 |
| AaveV3ArbitrumEModes                                                          |       45 |     24,531 |
| AaveV3Arbitrum_AdjustingInterestRateCurveForWeETHOnArbitrum_20240603          |    3,923 |     20,653 |
| AaveV3Arbitrum_ChaosLabsRiskParameterUpdatesAaveV3_20240530                   |    3,376 |     21,200 |
| AaveV3Arbitrum_GHOCrossChainLaunchPart2_20240613                              |    4,981 |     19,595 |
| AaveV3Arbitrum_GHOCrossChainLaunch_20240528                                   |   14,274 |     10,302 |
| AaveV3Arbitrum_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425               |    3,669 |     20,907 |
| AaveV3Arbitrum_IncreaseCCIPFacilitatorCapacity_20240707                       |      267 |     24,309 |
| AaveV3Arbitrum_IncreaseUSDCeRF_20240528                                       |    3,400 |     21,176 |
| AaveV3Arbitrum_MigrateRobotsToChainlinkAutomationV2_20240422                  |    2,954 |     21,622 |
| AaveV3Arbitrum_OptimizeETHCorrelatedAssetParameters_20240612                  |    3,622 |     20,954 |
| AaveV3Arbitrum_SetACIAsEmissionManager_20240620                               |      285 |     24,291 |
| AaveV3Arbitrum_StablecoinIRCurveAmendment_20240714                            |    4,878 |     19,698 |
| AaveV3Arbitrum_StablecoinIRUpdates_20240424                                   |    5,381 |     19,195 |
| AaveV3Avalanche                                                               |       45 |     24,531 |
| AaveV3AvalancheAssets                                                         |       45 |     24,531 |
| AaveV3AvalancheEModes                                                         |       45 |     24,531 |
| AaveV3Avalanche_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425              |    3,377 |     21,199 |
| AaveV3Avalanche_MigrateRobotsToChainlinkAutomationV2_20240422                 |    3,577 |     20,999 |
| AaveV3Avalanche_OptimizeETHCorrelatedAssetParameters_20240612                 |    3,623 |     20,953 |
| AaveV3Avalanche_SetACIAsEmissionManagerForWAVAXOnTheAvalancheNetwork_20240620 |      615 |     23,961 |
| AaveV3Avalanche_StablecoinIRCurveAmendment_20240714                           |    4,377 |     20,199 |
| AaveV3Avalanche_StablecoinIRUpdates_20240424                                  |    4,628 |     19,948 |
| AaveV3BNB                                                                     |       45 |     24,531 |
| AaveV3BNBAssets                                                               |       45 |     24,531 |
| AaveV3BNBEModes                                                               |       45 |     24,531 |
| AaveV3BNB_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425                    |    3,528 |     21,048 |
| AaveV3BNB_OptimizeETHCorrelatedAssetParameters_20240612                       |    3,629 |     20,947 |
| AaveV3BNB_StablecoinIRCurveAmendment_20240714                                 |    4,132 |     20,444 |
| AaveV3BNB_StablecoinIRUpdates_20240424                                        |    4,132 |     20,444 |
| AaveV3Base                                                                    |       45 |     24,531 |
| AaveV3BaseAssets                                                              |       45 |     24,531 |
| AaveV3BaseEModes                                                              |       45 |     24,531 |
| AaveV3Base_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425                   |    3,517 |     21,059 |
| AaveV3Base_IncreaseUSDCeRF_20240528                                           |    3,396 |     21,180 |
| AaveV3Base_IncreaseWeETHCapsOnBase_20240714                                   |    3,255 |     21,321 |
| AaveV3Base_OptimizeETHCorrelatedAssetParameters_20240612                      |    3,605 |     20,971 |
| AaveV3Base_StablecoinIRCurveAmendment_20240714                                |    3,618 |     20,958 |
| AaveV3Base_StablecoinIRUpdates_20240424                                       |    3,868 |     20,708 |
| AaveV3Base_WeETHAaveV3BaseOnboarding_20240527                                 |    4,997 |     19,579 |
| AaveV3Ethereum                                                                |       45 |     24,531 |
| AaveV3EthereumAssets                                                          |       45 |     24,531 |
| AaveV3EthereumEModes                                                          |       45 |     24,531 |
| AaveV3Ethereum_ACIAdAstra_20240506                                            |      835 |     23,741 |
| AaveV3Ethereum_AaveV31CantinaCompetition_20240503                             |      344 |     24,232 |
| AaveV3Ethereum_AprilFinanceUpdatePartB_20240515                               |    4,488 |     20,088 |
| AaveV3Ethereum_GHOCrossChainLaunch_20240528                                   |   18,000 |      6,576 |
| AaveV3Ethereum_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425               |    3,669 |     20,907 |
| AaveV3Ethereum_GhoStewardUpdate_20240602                                      |    2,571 |     22,005 |
| AaveV3Ethereum_IncreaseCCIPFacilitatorCapacity_20240707                       |      222 |     24,354 |
| AaveV3Ethereum_LlamariskRiskProvider_20240421                                 |      641 |     23,935 |
| AaveV3Ethereum_MigrateRobotsToChainlinkAutomationV2_20240422                  |    5,800 |     18,776 |
| AaveV3Ethereum_OnboardSUSDeToAaveV3OnEthereum_20240621                        |    5,006 |     19,570 |
| AaveV3Ethereum_OnboardUSDeAaveV3Ethereum_20240528                             |    5,012 |     19,564 |
| AaveV3Ethereum_OnboardingETHxToAaveV3_20240521                                |    5,000 |     19,576 |
| AaveV3Ethereum_OptimizeETHCorrelatedAssetParameters_20240612                  |    3,622 |     20,954 |
| AaveV3Ethereum_OrbitProgramRenewal_20240513                                   |    1,670 |     22,906 |
| AaveV3Ethereum_RequestForBountyPayoutJune2024_20240702                        |      740 |     23,836 |
| AaveV3Ethereum_SetACIAsEmissionManager_20240620                               |      323 |     24,253 |
| AaveV3Ethereum_StablecoinIRCurveAmendment_20240714                            |    5,130 |     19,446 |
| AaveV3Ethereum_StablecoinIRUpdates_20240424                                   |    5,130 |     19,446 |
| AaveV3Ethereum_StkGHOIncentives_20240424                                      |    1,476 |     23,100 |
| AaveV3Ethereum_UpdatingWeETHRiskParameters_20240426                           |    4,111 |     20,465 |
| AaveV3Ethereum_V4ALServiceProviderProposal_20240614                           |      840 |     23,736 |
| AaveV3Gnosis                                                                  |       45 |     24,531 |
| AaveV3GnosisAssets                                                            |       45 |     24,531 |
| AaveV3GnosisEModes                                                            |       45 |     24,531 |
| AaveV3Gnosis_AprilFinanceUpdate_20240421                                      |      380 |     24,196 |
| AaveV3Gnosis_ChaosLabsRiskParameterUpdatesAaveV3_20240530                     |    3,374 |     21,202 |
| AaveV3Gnosis_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425                 |    3,519 |     21,057 |
| AaveV3Gnosis_OptimizeETHCorrelatedAssetParameters_20240612                    |    3,620 |     20,956 |
| AaveV3Gnosis_StablecoinIRCurveAmendment_20240714                              |    4,123 |     20,453 |
| AaveV3Gnosis_StablecoinIRUpdates_20240424                                     |    4,123 |     20,453 |
| AaveV3Metis                                                                   |       45 |     24,531 |
| AaveV3MetisAssets                                                             |       45 |     24,531 |
| AaveV3MetisEModes                                                             |       45 |     24,531 |
| AaveV3Metis_OptimizeETHCorrelatedAssetParameters_20240612                     |    3,606 |     20,970 |
| AaveV3Optimism                                                                |       45 |     24,531 |
| AaveV3OptimismAssets                                                          |       45 |     24,531 |
| AaveV3OptimismEModes                                                          |       45 |     24,531 |
| AaveV3Optimism_ChaosLabsParameterRecommendationsSUSDOnV3Optimism_20240528     |    3,973 |     20,603 |
| AaveV3Optimism_ChaosLabsRiskParameterUpdatesAaveV3_20240530                   |    3,363 |     21,213 |
| AaveV3Optimism_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425               |    3,669 |     20,907 |
| AaveV3Optimism_IncreaseUSDCeRF_20240528                                       |    3,400 |     21,176 |
| AaveV3Optimism_MigrateRobotsToChainlinkAutomationV2_20240422                  |    2,844 |     21,732 |
| AaveV3Optimism_OptimizeETHCorrelatedAssetParameters_20240612                  |    3,609 |     20,967 |
| AaveV3Optimism_SUSDRiskParametersUpdate_20240517                              |    3,372 |     21,204 |
| AaveV3Optimism_StablecoinIRCurveAmendment_20240714                            |    4,878 |     19,698 |
| AaveV3Optimism_StablecoinIRUpdates_20240424                                   |    5,130 |     19,446 |
| AaveV3Polygon                                                                 |       45 |     24,531 |
| AaveV3PolygonAssets                                                           |       45 |     24,531 |
| AaveV3PolygonEModes                                                           |       45 |     24,531 |
| AaveV3Polygon_ChaosLabsRiskParameterUpdatesAaveV3_20240530                    |    3,520 |     21,056 |
| AaveV3Polygon_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425                |    3,668 |     20,908 |
| AaveV3Polygon_IncreaseUSDCeRF_20240528                                        |    3,399 |     21,177 |
| AaveV3Polygon_MigrateRobotsToChainlinkAutomationV2_20240422                   |    2,773 |     21,803 |
| AaveV3Polygon_OptimizeETHCorrelatedAssetParameters_20240612                   |    3,621 |     20,955 |
| AaveV3Polygon_StablecoinIRCurveAmendment_20240714                             |    4,877 |     19,699 |
| AaveV3Polygon_StablecoinIRUpdates_20240424                                    |    5,380 |     19,196 |
| AaveV3Scroll                                                                  |       45 |     24,531 |
| AaveV3ScrollAssets                                                            |       45 |     24,531 |
| AaveV3ScrollEModes                                                            |       45 |     24,531 |
| AaveV3Scroll_GeneralizedLTLTVReductionsOnAaveV3Step2_20240425                 |    3,374 |     21,202 |
| AaveV3Scroll_OptimizeETHCorrelatedAssetParameters_20240612                    |    3,607 |     20,969 |
| AaveV3Scroll_StablecoinIRCurveAmendment_20240714                              |    3,620 |     20,956 |
| AaveV3Scroll_StablecoinIRUpdates_20240424                                     |    3,620 |     20,956 |
| Address                                                                       |       45 |     24,531 |
| AggregateRateLimiter                                                          |    1,931 |     22,645 |
| CallWithExactGas                                                              |       45 |     24,531 |
| ChainHelpers                                                                  |       45 |     24,531 |
| ChainIds                                                                      |       45 |     24,531 |
| Client                                                                        |      111 |     24,465 |
| ConfiguratorInputTypes                                                        |       45 |     24,531 |
| ConfirmedOwner                                                                |      552 |     24,024 |
| ConfirmedOwnerWithProposal                                                    |      552 |     24,024 |
| Create2Utils                                                                  |      123 |     24,453 |
| DataTypes                                                                     |       45 |     24,531 |
| ERC165Checker                                                                 |       45 |     24,531 |
| ERC1967Proxy                                                                  |      136 |     24,440 |
| EVM2EVMOffRamp                                                                |   19,826 |      4,750 |
| EVM2EVMOnRamp                                                                 |   20,900 |      3,676 |
| EngineFlags                                                                   |       45 |     24,531 |
| EnumerableMap                                                                 |       45 |     24,531 |
| EnumerableMapAddresses                                                        |       45 |     24,531 |
| EnumerableSet                                                                 |       45 |     24,531 |
| Errors                                                                        |    4,673 |     19,903 |
| GovV3Helpers                                                                  |    2,581 |     21,995 |
| GovV3StorageHelpers                                                           |       45 |     24,531 |
| GovernanceV3Arbitrum                                                          |       45 |     24,531 |
| GovernanceV3Avalanche                                                         |       45 |     24,531 |
| GovernanceV3BNB                                                               |       45 |     24,531 |
| GovernanceV3Base                                                              |       45 |     24,531 |
| GovernanceV3Ethereum                                                          |       45 |     24,531 |
| GovernanceV3Gnosis                                                            |       45 |     24,531 |
| GovernanceV3Metis                                                             |       45 |     24,531 |
| GovernanceV3Optimism                                                          |       45 |     24,531 |
| GovernanceV3Polygon                                                           |       45 |     24,531 |
| GovernanceV3PolygonZkEvm                                                      |       45 |     24,531 |
| GovernanceV3Scroll                                                            |       45 |     24,531 |
| Internal                                                                      |      147 |     24,429 |
| IpfsUtils                                                                     |       45 |     24,531 |
| Math                                                                          |       45 |     24,531 |
| MerkleMultiProof                                                              |       45 |     24,531 |
| MiscArbitrum                                                                  |       45 |     24,531 |
| MiscEthereum                                                                  |       45 |     24,531 |
| MiscPolygon                                                                   |       45 |     24,531 |
| OrbitProgramData                                                              |      422 |     24,154 |
| OwnerIsCreator                                                                |      552 |     24,024 |
| PayloadsControllerUtils                                                       |       45 |     24,531 |
| PriceRegistry                                                                 |    5,352 |     19,224 |
| ProxyHelpers                                                                  |       45 |     24,531 |
| RateLimiter                                                                   |       45 |     24,531 |
| ReserveConfiguration                                                          |      130 |     24,446 |
| RewardsDataTypes                                                              |       45 |     24,531 |
| Router                                                                        |    8,873 |     15,703 |
| SafeCast                                                                      |       45 |     24,531 |
| SafeERC20                                                                     |       45 |     24,531 |
| StorageHelpers                                                                |       45 |     24,531 |
| StorageSlot                                                                   |       45 |     24,531 |
| Strings                                                                       |       45 |     24,531 |
| TestNetChainIds                                                               |       45 |     24,531 |
| TransparentUpgradeableProxy                                                   |    2,040 |     22,536 |
| USDPriceWith18Decimals                                                        |       45 |     24,531 |
| UpgradeableBurnMintTokenPool                                                  |    9,831 |     14,745 |
| UpgradeableGhoToken                                                           |    8,597 |     15,979 |
| Utils                                                                         |   15,014 |      9,562 |
| WadRayMath                                                                    |       45 |     24,531 |
Test error :finnadie:❌ 
No files changed, compilation skipped
2024-07-19T16:20:08.592804Z ERROR sharedbackend: Failed to send/recv `storage` err=failed to get storage for 0x89644CA1bB8064760312AE4F03ea41b05dA3637C at 25282575895542020817792990546266411070965414445424266158893344000287877184425: Max retries exceeded HTTP error 429 with body: error code: 1015 address=0x89644CA1bB8064760312AE4F03ea41b05dA3637C index=25282575895542020817792990546266411070965414445424266158893344000287877184425

Ran 1 test for src/20240707_AaveV3Ethereum_IncreaseCCIPFacilitatorCapacity/AaveV3Arbitrum_IncreaseCCIPFacilitatorCapacity_20240707.t.sol:AaveV3Arbitrum_IncreaseCCIPFacilitatorCapacity_20240707_Test
[FAIL. Reason: failed to get storage for 0x89644CA1bB8064760312AE4F03ea41b05dA3637C at 25282575895542020817792990546266411070965414445424266158893344000287877184425: Max retries exceeded HTTP error 429 with body: error code: 1015] test_newLimitIsSet() (gas: 47850)
Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 7.26s (6.99s CPU time)

Ran 1 test suite in 7.27s (7.26s CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests)

Failing tests:
Encountered 1 failing test in src/20240707_AaveV3Ethereum_IncreaseCCIPFacilitatorCapacity/AaveV3Arbitrum_IncreaseCCIPFacilitatorCapacity_20240707.t.sol:AaveV3Arbitrum_IncreaseCCIPFacilitatorCapacity_20240707_Test
[FAIL. Reason: failed to get storage for 0x89644CA1bB8064760312AE4F03ea41b05dA3637C at 25282575895542020817792990546266411070965414445424266158893344000287877184425: Max retries exceeded HTTP error 429 with body: error code: 1015] test_newLimitIsSet() (gas: 47850)

Encountered a total of 1 failing tests, 0 tests succeeded
No files changed, compilation skipped
2024-07-19T16:20:18.894224Z ERROR sharedbackend: Failed to send/recv `storage` err=failed to get storage for 0x7109709ECfa91a80626fF3989D68f67F5b1DD12D at 46308022326495007027972728677917914892729792999299745830475596687180801507328: Max retries exceeded HTTP error 429 with body: error code: 1015 address=0x7109709ECfa91a80626fF3989D68f67F5b1DD12D index=46308022326495007027972728677917914892729792999299745830475596687180801507328
2024-07-19T16:20:31.609105Z ERROR sharedbackend: Failed to send/recv `storage` err=failed to get storage for 0x89644CA1bB8064760312AE4F03ea41b05dA3637C at 81955473079516046949633743016697847541294818689821282749996681496272635257091: Max retries exceeded HTTP error 429 with body: error code: 1015 address=0x89644CA1bB8064760312AE4F03ea41b05dA3637C index=81955473079516046949633743016697847541294818689821282749996681496272635257091

Ran 1 test for src/20240707_AaveV3Ethereum_IncreaseCCIPFacilitatorCapacity/AaveV3E2ETest_IncreaseCCIPFacilitatorCapacity.t.sol:AaveV3E2ETest_IncreaseCCIPFacilitatorCapacity
[FAIL. Reason: backend: failed while inspecting] test_ccipFullE2E() (gas: 0)
Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 22.02s (12.71s CPU time)

Ran 1 test suite in 22.02s (22.02s CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests)

Failing tests:
Encountered 1 failing test in src/20240707_AaveV3Ethereum_IncreaseCCIPFacilitatorCapacity/AaveV3E2ETest_IncreaseCCIPFacilitatorCapacity.t.sol:AaveV3E2ETest_IncreaseCCIPFacilitatorCapacity
[FAIL. Reason: backend: failed while inspecting] test_ccipFullE2E() (gas: 0)

Encountered a total of 1 failing tests, 0 tests succeeded
No files changed, compilation skipped

Ran 1 test for src/20240707_AaveV3Ethereum_IncreaseCCIPFacilitatorCapacity/AaveV3Ethereum_IncreaseCCIPFacilitatorCapacity_20240707.t.sol:AaveV3Ethereum_IncreaseCCIPFacilitatorCapacity_20240707_Test
[PASS] test_newLimitIsSet() (gas: 100383)
Suite result: ok. 1 passed; 0 failed; 0 skipped; finished in 3.29s (641.41ms CPU time)

Ran 1 test suite in 3.29s (3.29s CPU time): 1 tests passed, 0 failed, 0 skipped (1 total tests)

@brotherlymite brotherlymite merged commit 72deb3b into bgd-labs:main Jul 19, 2024
3 of 4 checks passed
@efecarranza efecarranza deleted the facilitator branch July 31, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matt-Graham-TL Matt-Graham-TL Matt-Graham-TL left review comments

@miguelmtzinf miguelmtzinf miguelmtzinf left review comments

@pavelvm5 pavelvm5 pavelvm5 approved these changes

@brotherlymite brotherlymite brotherlymite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@efecarranza @miguelmtzinf @brotherlymite @pavelvm5 @Matt-Graham-TL